Improvement of API requests error handling #1141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: (145 commits) Add missing toc cypress changelog Add div with class "table-of-contents" to ToC block (#1311) Fix Maps block to use maps-inner instead of video-inner class (#1310) Cypress Video Block improvements (#1309) Revert "Fix refresh of the `Breadcrumbs` and `Navigation` components on calling `/login` and `/logout` (#1292)" Reenable video blocks cypress tests based on the rework on lazy load branch (#1308) Adjust implementation of the download link behavior for files (#1307) Comment out flaky blocks-video.js test. Comment out flaky video block Cypress tests. Fix Travis (#1306) Toc cypress (#1253) Update .gitignore. fix makefile fix Makefile Do not rely on virtualenv. Upgrade critical Plone 5.2.1 deps in api folder (#1293) Fix refresh of the `Breadcrumbs` and `Navigation` components on calling `/login` and `/logout` (#1292) Fix typo for Japanese translation (#1284) Back to development Release 4.1.1 ...
* master: (95 commits) Back to development Release 5.1.0 Prepare for release added errors handling in Add and Edit forms (#1410) Remove back button, and remove last @ decorator from UserControlPanel (#1409) Fullscreen sidebar (#1369) Dates widget: show past dates and mark differently default value (#1407) Folder content style (#1343) Translations for event view labels (#1389) Enable internal API proxy for not to rely on CORS on development (#1390) Translation ja 202004 (#1406) Fix `ArrayWidget` to support multiselect schema `schema.List`/`schema… (#1405) fix various tests (#1403) internal: Improve i18n script, so shadowed components are not overriding their … (#1402) Removing navbar, breadcrumbs, search icon from print (#1393) Back to development Release 5.0.1 Prepare for release fixes for contact form (#1378) Added Stradanove to "Volto in Production" (#1377) ...
nzambello
approved these changes
Apr 24, 2020
|
@sneridagh w00t! Awesome!!! |
|
Seems a Cypress test (folder contents) fails on both GH actions and Travis. |
tiberiuichim
approved these changes
Apr 25, 2020
src/middleware/api.js
Outdated
| SET_APIERROR, | ||
| } from '@plone/volto/constants/ActionTypes'; | ||
|
|
||
| const ACTIONS_RAISING_ERRORS = ['GET_CONTENT', 'UPDATE_CONTENT']; |
There was a problem hiding this comment.
Could this be read from config.settings? This way it would be extensible without customizing api.js
|
@tiberiuichim done as suggested! I think now will be green |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plone/plone.rest#101 is solved now, however, on GET we can't get a 403 now :( plone/plone.restapi#893
@robgietema do you want to take a look?
/cc @tisto