Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(config): add support for config.yaml file #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

hazzadous
Copy link

Support for specifying a config.yaml config file was added
here. I'm not
sure if this is the best way to add support for this, but would love to
have the ability to specify the databases as part of the Helm Chart
values.

@hazzadous hazzadous force-pushed the feat/add-support-for-config-file branch from 4fa1333 to 8fe95c9 Compare November 11, 2022 14:20
Support for specifying a config.yaml config file was added
[here](https://github.com/metabase/metabase/pull/25986/files). I'm not
sure if this is the best way to add support for this, but would love to
have the ability to specify the databases as part of the Helm Chart
values.
@hazzadous hazzadous force-pushed the feat/add-support-for-config-file branch from 8fe95c9 to c85e3a3 Compare November 11, 2022 14:22
@pmint93
Copy link
Owner

pmint93 commented Nov 17, 2022

Thanks @hazzadous for contributing,

Please bump the chart version in Chart.yaml and ...
From which version this config file was supported ? Can we also bump the metabase version accordingly ?

@ellie
Copy link

ellie commented Nov 18, 2022

Hey @pmint93! I've bumped the chat version + would love to see this merged 🙏

From which version this config file was supported ? Can we also bump the metabase version accordingly ?

Looks like the change was added ~30 days ago: metabase/metabase#25986

But I can't see it in the latest release :(

@hazzadous
Copy link
Author

Hah thanks @ellie 🤞 it makes it in the next release. #untested

@pmint93
Copy link
Owner

pmint93 commented Nov 21, 2022

@hazzadous @ellie So I think we should wait for the release & official document of how to properly configure it

Copy link
Owner

@pmint93 pmint93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The release v0.45.1 has been out with instruction to configure it to load config file

And with #49 has been merged, we have some conflicts that need resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants