Improve PHPDocs, push to PHPStan level 10

phpstan.neon.dist

@@ -3,7 +3,7 @@ includes:
 	- tests/phpstan/configs/phpstan-bugs.neon
 
 parameters:
-	level: 9
+	level: 10
 	treatPhpDocTypesAsCertain: false
 	paths:
 		- src

src/BaseNbtSerializer.php

@@ -99,6 +99,7 @@ public function readHeadless(string $buffer, int $rootType, int &$offset = 0, in
 	 * TODO: This is only necessary because we don't have a streams API worth mentioning. Get rid of this in the future.
 	 *
 	 * @return TreeRoot[]
+	 * @phpstan-return list<TreeRoot>
 	 * @throws NbtDataException
 	 */
 	public function readMultiple(string $buffer, int $maxDepth = 0) : array{

src/BigEndianNbtSerializer.php

@@ -80,6 +80,7 @@ public function readIntArray() : array{
 		if($len < 0){
 			throw new NbtDataException("Array length cannot be less than zero ($len < 0)");
 		}
+		/** @var array<int>|false $unpacked */
 		$unpacked = unpack("N*", $this->buffer->get($len * 4));
 		assert($unpacked !== false, "The formatting string is valid, and we gave a multiple of 4 bytes");
 		return array_values($unpacked);

src/LittleEndianNbtSerializer.php

@@ -80,6 +80,7 @@ public function readIntArray() : array{
 		if($len < 0){
 			throw new NbtDataException("Array length cannot be less than zero ($len < 0)");
 		}
+		/** @var array<int>|false $unpacked */
 		$unpacked = unpack("V*", $this->buffer->get($len * 4));
 		assert($unpacked !== false, "The formatting string is valid, and we gave a multiple of 4 bytes");
 		return array_values($unpacked);

src/NbtStreamReader.php

@@ -82,6 +82,7 @@ public function readString() : string;
 
 	/**
 	 * @return int[]
+	 * @phpstan-return list<int>
 	 * @throws BinaryDataException
 	 */
 	public function readIntArray() : array;

src/NbtStreamWriter.php

@@ -49,6 +49,7 @@ public function writeString(string $v) : void;
 
 	/**
 	 * @param int[] $array
+	 * @phpstan-param list<int> $array
 	 */
 	public function writeIntArray(array $array) : void;
 }

src/tag/IntArrayTag.php

@@ -26,17 +26,22 @@
 use pocketmine\nbt\NBT;
 use pocketmine\nbt\NbtStreamReader;
 use pocketmine\nbt\NbtStreamWriter;
+use function array_values;
 use function assert;
 use function func_num_args;
 use function implode;
 use function is_int;
 
 final class IntArrayTag extends ImmutableTag{
-	/** @var int[] */
+	/**
+	 * @var int[]
+	 * @phpstan-var list<int>
+	 */
 	private $value;
 
 	/**
 	 * @param int[] $value
+	 * @phpstan-param list<int> $value
 	 */
 	public function __construct(array $value){
 		self::restrictArgCount(__METHOD__, func_num_args(), 1);
@@ -50,7 +55,7 @@ public function __construct(array $value){
 			return true;
 		})());
 
-		$this->value = $value;
+		$this->value = array_values($value);
 	}
 
 	protected function getTypeName() : string{
@@ -75,6 +80,7 @@ protected function stringifyValue(int $indentation) : string{
 
 	/**
 	 * @return int[]
+	 * @phpstan-return list<int>
 	 */
 	public function getValue() : array{
 		return $this->value;

src/tag/ListTag.php

@@ -61,11 +61,12 @@ public function __construct(array $value = [], int $tagType = NBT::TAG_End){
 
 	/**
 	 * @return Tag[]
+	 * @phpstan-return list<Tag>
 	 */
 	public function getValue() : array{
 		$value = [];
-		foreach($this->value as $k => $v){
-			$value[$k] = $v;
+		foreach($this->value as $v){
+			$value[] = $v;
 		}
 
 		return $value;