Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update InstantDamage and Regeneration values #5279

Merged
merged 1 commit into from
Sep 15, 2022

Conversation

IvanCraft623
Copy link
Member

@IvanCraft623 IvanCraft623 commented Sep 5, 2022

Introduction

While working on #5276 I realized that were outdated.

Tests

Data were obtained from https://minecraft.fandom.com/wiki/Potion and has been play-tested to match with vanilla

Copy link
Contributor

@ColinHDev ColinHDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, I've looked into this and the changes to Instant Damage look good and match both the wiki as well as in-game.
But while checking the wiki page of the regeneration effect, I noticed this: Amplifiers outside the range 0–31 (corresponding to levels 1–32) are used modulo 32, making level 33 the same as level 1, etc.
I know, that we don't aim for bug parity here, but I am not sure whether this counts as a bug and should be left as is in the code or modified to match Mojangs weird behaviour.

@dktapps
Copy link
Member

dktapps commented Sep 15, 2022

I don't think it matters. No one will notice anyway, and if someone does try to use such a high level, they'll think the modulo behaviour itself is a bug.

@dktapps dktapps merged commit 9f97654 into pmmp:next-minor Sep 15, 2022
@IvanCraft623 IvanCraft623 deleted the effect-values branch September 16, 2022 00:00
@dktapps dktapps added this to the 4.10 milestone Nov 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants