Implement firework rocket & firework star #5455
Conversation
dktapps
added
Category: Gameplay
|
Missing features:
|
Also with crossbows, but it can wait until those are implemented first. |
|
A PR doesn't have to be all in one, I think the current features are sufficient, the remaining ones are not critical. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Co-authored-by: ipad54 <[email protected]>
|
For posterity: firework rocket entity also has a long metadata property We don't have elytras implemented right now so I think we don't have to bother about this and the PR looks finished for me. |
|
|
||
| /** | ||
| * TODO: The entity should be saved and loaded, but this is not possible. | ||
| * @see https://bugs.mojang.com/browse/MCPE-165230 |
There was a problem hiding this comment.
Not liking this. We should still save & restore them in PM, regardless of vanilla bugs that don't store them.
| /** | ||
| * Returns maximum number of ticks this will live for. | ||
| */ | ||
| public function getLifeTicks() : int{ |
There was a problem hiding this comment.
getMaxAgeTicks() would be more clear IMO
| * | ||
| * @return $this | ||
| */ | ||
| public function setLifeTicks(int $lifeTicks) : self{ |
| $position = match($face){ | ||
| Facing::DOWN => $position->add(0, -$correction, 0), | ||
| Facing::UP => $position->add(0, $correction, 0), | ||
| Facing::NORTH => $position->add(0, 0, -$correction), | ||
| Facing::SOUTH => $position->add(0, 0, $correction), | ||
| Facing::WEST => $position->add(-$correction, 0, 0), | ||
| Facing::EAST => $position->add($correction, 0, 0), | ||
| default => throw new AssumptionFailedError("Invalid facing $face") | ||
| }; |
There was a problem hiding this comment.
| $position = match($face){ | |
| Facing::DOWN => $position->add(0, -$correction, 0), | |
| Facing::UP => $position->add(0, $correction, 0), | |
| Facing::NORTH => $position->add(0, 0, -$correction), | |
| Facing::SOUTH => $position->add(0, 0, $correction), | |
| Facing::WEST => $position->add(-$correction, 0, 0), | |
| Facing::EAST => $position->add($correction, 0, 0), | |
| default => throw new AssumptionFailedError("Invalid facing $face") | |
| }; | |
| $position = $position->add(Vector3::zero()->getSide($face)->multiply($correction)); |
If we allowed getSide() to accept float values, this would be even simpler.
| default => throw new AssumptionFailedError("Invalid facing $face") | ||
| }; | ||
|
|
||
| $randomDuration = (($this->flightDurationMultiplier + 1) * 10) + mt_rand(0, 12); |
There was a problem hiding this comment.
Prefer if these magic numbers were moved to constants.
![pmmp-admin-bot[bot]](https://avatars.githubusercontent.com/in/1059952?s=60&v=4){kind=small}
Introduction
Implement items:
Firework Rocket,Firework Starand entity:Firework Rocket.Follow-up
Requires translations:
death.attack.fireworks{%0} went off with a bangTests
https://youtu.be/kHs_nBmLRhs