Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Many improvements #1

Open
wants to merge 51 commits into
base: master
Choose a base branch
from
Open

Many improvements #1

wants to merge 51 commits into from

Conversation

r-barnes
Copy link

@r-barnes r-barnes commented Apr 6, 2018

I've been working with the code a bit and introduced some improvments:

  • Modifications to suppress compilation warnings due to signedness.
  • Cleaning of README.md file
  • Modifications so code can be compiled with the C++11 standard rather than the C++1z standard, allowing for usage in a broader range of development environments.
  • Introduction of link-time optimization, which may lead to improved performance.
  • Inclusion of the -g flag in compilation, since this doesn't affect speed, but does improve debugging capabilities.
  • Introduction of a single script RUN.sh which performs all the operations described in the README.md file.
  • Movement of licensing info to its own file.
  • Addition of a script extract_district_boundaries.py which exports districts to a form compatible with standard GIS software.
  • Increasing the number of iterations before the program raises a "failure to converge" message.
  • Use of the const modifier at various points in the code.
  • Command-line argument checking in do_redistrict.cpp.

r-barnes added 30 commits March 10, 2018 12:01
Added `unsigned` for various loop iteration variables to suppress warnings.

Added exception at the end of the function; without this the function returns uninitialized centers if max tries is reached without convergence. This is a bad idea.
…n a non-performance-critical vector access.
… do for diagnosing performance issues and exceptions.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant