Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New command: m365 exo approleassignment add. Closes #5988 #6407

Closed
wants to merge 8 commits into from
Closed

New command: m365 exo approleassignment add. Closes #5988 #6407

wants to merge 8 commits into from

Conversation

MartinM85
Copy link
Contributor

Closes #5988

@milanholemans
Copy link
Contributor

Thank you @MartinM85, we'll try to review it ASAP!

@Adam-it Adam-it added the hacktoberfest-accepted Accept for hacktoberfest, will merge later label Oct 29, 2024
@Adam-it
Copy link
Member

Adam-it commented Oct 29, 2024

@MartinM85 I added the hacktoberfest-accepted label to this PR which means that this PR will count as done for the Hacktoberfest event. So if you participate in this event it will get you unblocked and it allows us to merge this PR later when we catch up 👍
Thanks for your support and awesome contribution 👏 You Rock 🤩

@martinlingstuyl martinlingstuyl self-assigned this Dec 11, 2024
martinlingstuyl
martinlingstuyl requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have but a few comments @MartinM85, the code looks good to me. Solid as always.

They only thing is that I'd still like to have a little discussion on the command specs before we merge this in. Sorry for that 😅, but as soon as it's in the codebase it's much harder to change.

docs/docs/cmd/exchange/role-assignment/role-assignment-add.mdx Outdated Show resolved Hide resolved
docs/docs/cmd/exchange/role-assignment/role-assignment-add.mdx Outdated Show resolved Hide resolved
src/m365/exchange/commands/roleassignment/role-assignment-add.ts Outdated Show resolved Hide resolved
src/utils/entraServicePrincipal.ts Outdated Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft December 11, 2024 21:10
@MartinM85 MartinM85 force-pushed the feature/5988-exchange-role-assignment-add branch from eb00084 to 00570db Compare December 29, 2024 18:48
@MartinM85 MartinM85 changed the title New command: m365 exchange role assignment add. Closes #5988 New command: m365 exo approleassignment add. Closes #5988 Dec 29, 2024
@MartinM85 MartinM85 marked this pull request as ready for review December 29, 2024 19:05
@MartinM85
Copy link
Contributor Author

@martinlingstuyl The command rewritten.

martinlingstuyl
martinlingstuyl requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better like this. Almost ready to merge!

docs/docs/cmd/exo/approleassignment/approleassignment-add.mdx Show resolved Hide resolved
src/utils/entraServicePrincipal.ts Outdated Show resolved Hide resolved
src/utils/entraServicePrincipal.ts Outdated Show resolved Hide resolved
@martinlingstuyl martinlingstuyl marked this pull request as draft January 2, 2025 16:24
@MartinM85 MartinM85 marked this pull request as ready for review January 3, 2025 07:45
martinlingstuyl
martinlingstuyl approved these changes Jan 6, 2025
View reviewed changes
Copy link
Contributor

@martinlingstuyl martinlingstuyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @MartinM85, I'll merge it soon!

src/utils/entraServicePrincipal.ts Outdated Show resolved Hide resolved
src/utils/entraServicePrincipal.ts Outdated Show resolved Hide resolved
@martinlingstuyl
Copy link
Contributor

Merged manually, thank you!!! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinlingstuyl martinlingstuyl martinlingstuyl approved these changes

Assignees

@martinlingstuyl martinlingstuyl

Labels
hacktoberfest-accepted Accept for hacktoberfest, will merge later pr-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New command: m365 exo approleassignment add
4 participants
@MartinM85 @milanholemans @Adam-it @martinlingstuyl