Support pasting layout XML from outside of IntelliJ / Android Studio #8 #81
Conversation
| return emptyList() | ||
| return if (content.isDataFlavorSupported(DataFlavor.stringFlavor)) { | ||
| val text = content.getTransferData(DataFlavor.stringFlavor) as String | ||
| val xmlPreamble = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" |
| ) | ||
| } | ||
| text.contains(xmlPreamble, true) -> { | ||
| listOf(CopiedXMLCode(text, intArrayOf(0), intArrayOf(0)) as TextBlockTransferableData) |
There was a problem hiding this comment.
Shouldn't we set the endOffset to the last index of text? Right now the offsets are not used, but eventually they will, I guess (#5).
There was a problem hiding this comment.
To be honest, i wasn't sure what the correct values for the offsets are. I looked at what offsets are used in collectTransferableData() when i copy the text inside Intellij and they we both 0.
There was a problem hiding this comment.
Oh, I see. Then this is something to look at when tackling #5. I was expecting the offsets to mark the selection area inside the text, since right now that always contains the whole document. But if it's always 0 right now then let's just use 0 here for now too. 👍
| val xmlPreamble = "<?xml version=\"1.0\" encoding=\"UTF-8\"?>" | ||
|
|
||
| when { | ||
| content.isDataFlavorSupported(CopiedXMLCode.DATA_FLAVOR) -> { |
There was a problem hiding this comment.
Do we ever get here if this block is wrapped in DataFlavor.stringFlavor? Is that an extension of the string flavor?
There was a problem hiding this comment.
Yes, we can only get here when the content has one flavour with DataFlavor.stringFlavor, see row 63.
I'm first checking if the pasted content is a string and not e.g. an image file. Then i'm checking if the content also has the dataflavor of CopiedXMLCode. If it's not, i'm checking if it looks like XML.
Hi, maybe there's a better way to check if a string is XML but i found a similar approach in the Kotlin Project