chore(ci): add scripts to prepare test env. for podman-desktop E2E tests #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… e2e Signed-off-by: Ondrej Dockal <[email protected]>
|
I am not against this but the problem I see is use Same for pd-compose-e2e, ? Maybe I am missing one benefit for this. One hidden benefit to have the scripts inside image is i.e. testing airgap scenarios wher you can not use external url to get the script . |
|
Note: probably I am saying things not accurate cause I did not understand deeply the use case |
|
Closing in favor of another approach as discussed with @adrianriobo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #243.
First proposal for the scripts to run on particular platforms to prepare to run podman desktop e2e tests: testing podman-remote feature.