feat: preserve extra fields in text event responses #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Pass complete data_dict to BotMessage.data field - Add unit tests for extra fields handling Allows direct access to additional fields (e.g., waiting_time_us) through BotMessage.data
YushengAuggie
requested review from
JelleZijlstra,
chunho,
JohntheLi and
krisyang1125
- Pass complete data_dict to BotMessage.data field - Add unit tests for extra fields handling Allows direct access to additional fields (e.g., waiting_time_us) through BotMessage.data
- Pass complete data_dict to BotMessage.data field - Add unit tests for extra fields handling Allows direct access to additional fields (e.g., waiting_time_us) through BotMessage.data
994125010
reviewed
Nov 15, 2024
| @@ -297,7 +298,8 @@ async def post_message_attachment( | |||
| filename: Optional[str] = None, | |||
| content_type: Optional[str] = None, | |||
| is_inline: bool = False, | |||
| ) -> AttachmentUploadResponse: ... | |||
| ) -> AttachmentUploadResponse: | |||
| ... | |||
994125010
reviewed
Nov 15, 2024
| def text_event(text: str) -> ServerSentEvent: | ||
| return ServerSentEvent(data=json.dumps({"text": text}), event="text") | ||
| def text_event( | ||
| text: str, data: Optional[Dict[str, Any]] = dict() |
There was a problem hiding this comment.
let's make this data: Optional[MappingProxyType] = None since we don't want default args and if we're passing this dict around, we prob want it to be read-only? (have ppl copy it like {**data} if they need to create a mutable copy)
994125010
reviewed
Nov 15, 2024
| assert isinstance(messages[0].raw_response, dict) | ||
| assert "text" in messages[0].raw_response | ||
| parsed_data = json.loads(messages[0].raw_response["text"]) | ||
| assert parsed_data.get("extra_field") == "extra_value" |
There was a problem hiding this comment.
let's have different values for these between the messages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows direct access to additional fields (e.g.,some_metrics) through BotMessage.data