feat: Add support for report_reaction endpoint #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ddharman-quora
commented
Dec 4, 2024
ddharman-quora
commented
- This is to support message reactions launch. This will replace report_feedback which will be marked deprecated but still functional. Will update documentation around launch time
- Tested end-to-end with server bot running locally and trying different reactions and verifying endpoint is called
- Some formatting changes are in here since I ran all the recommended steps in the documentation
- Updated version to 0.0.49
- This is to support message reactions launch. This will replace report_feedback which will be marked deprecated but still functional. Will update documentation around launch time - Tested end-to-end with server bot running locally and trying different reactions and verifying endpoint is called - Some formatting changes are in here since I ran all the recommended steps in the documentation - Updated version to 0.0.49
The tests are failing now because of formatting. Not sure what you ran, but running |
|
@JelleZijlstra Thanks! I have made the change. |
JelleZijlstra
approved these changes
Dec 4, 2024
There was a problem hiding this comment.
Looks good, but would like somebody from the owning team (maybe @krisyang1125) to take another look.
krisyang1125
approved these changes
Dec 4, 2024
JohntheLi
pushed a commit
to JohntheLi/fastapi_poe
that referenced
this pull request
Jan 6, 2025
* feat: Add support for report_reaction endpoint - This is to support message reactions launch. This will replace report_feedback which will be marked deprecated but still functional. Will update documentation around launch time - Tested end-to-end with server bot running locally and trying different reactions and verifying endpoint is called - Some formatting changes are in here since I ran all the recommended steps in the documentation - Updated version to 0.0.49 * Fix formatting errors by running pre-commit * Remove on_reaction and only keep on_reaction_with_context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.