Attachment upload API improvements #50
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Each attachment upload needs context from the query to know which message id and access key to use. Putting `post_message_attachment` on `QueryRequest` means that the user no longer needs to pass in the access key or message id
Summary: Add new `AttachFileResponse` and `ImageResponse` that bots can yield to attach files and images to their message.
… pydantic model Summary: doesn't need to be serializable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates new
AttachFileResponseandImageResponseobjects that bots can yield instead of needing to usepost_message_attachmentdirectlyMoved
post_message_attachmentontoQueryRequestso developers don't need to find and pass in the message id and access key. Kept the oldpost_message_attachmentonPoeBotfor compatibility.