Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Migration] scaffold: module migration #1032

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

bryanchriswhite
Copy link
Contributor

@bryanchriswhite bryanchriswhite commented Jan 17, 2025

Summary

ignite scaffold module migration

NOTE: The --dep flag consistently failed to work for me, resulting in the following error (for any dep module); e.g.:

✘ The module cannot have Account as a dependency: app doesn't contain AccountKeeper

Issue

Type of change

Select one or more from the following:

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@bryanchriswhite bryanchriswhite added on-chain On-chain business logic p0 Top priority consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. labels Jan 17, 2025
@bryanchriswhite bryanchriswhite self-assigned this Jan 17, 2025
@bryanchriswhite bryanchriswhite linked an issue Jan 20, 2025 that may be closed by this pull request
9 tasks
@bryanchriswhite bryanchriswhite force-pushed the scaffold/migration-module branch from 4338db9 to 6d9c3d9 Compare January 21, 2025 11:52
@bryanchriswhite bryanchriswhite marked this pull request as ready for review January 27, 2025 08:31
@Olshansk Olshansk self-requested a review January 29, 2025 17:50
@Olshansk Olshansk added the migration Morse to Shannon migration related work label Jan 29, 2025
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving but PTAL at the one small comment

app/app.go Outdated Show resolved Hide resolved
proto/poktroll/migration/params.proto Outdated Show resolved Hide resolved

// InitGenesis initializes the module's state from a provided genesis state.
func InitGenesis(ctx sdk.Context, k keeper.Keeper, genState types.GenesisState) {
// this line is used by starport scaffolding # genesis/module/init
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whitespace fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what the ask is here, could you please elaborate?

@@ -0,0 +1,35 @@
package migration
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use autocli this time.

Copy link
Contributor Author

@bryanchriswhite bryanchriswhite Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 - autoCLI only applies to the claim step though, so you'll see skip: true until #1046.

The state upload step requires authorization, which I would do the same way that we do param updates: authz dao genesis authorization + a make target + authz message JSON.

I don't think the export/import transform can't be done via autocli because it's not a gRPC service/message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. migration Morse to Shannon migration related work on-chain On-chain business logic p0 Top priority
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

[Morse->Shannon Migration] Migration module
2 participants