[Morse->Shannon Migration] scaffold: MorseAccountState single
#1045
Conversation
bryanchriswhite
added
on-chain
bryanchriswhite
force-pushed
the
issues/1034/scaffold/morse_account_state
branch
from
89b83f7 to
b720680
Compare
bryanchriswhite
force-pushed
the
issues/1034/scaffold/morse_account_state
branch
from
b720680 to
cf4a0c5
Compare
|
|
||
| } | ||
|
|
||
| // Queries a MorseAccountState by index. |
There was a problem hiding this comment.
- It is not clear to be what/where/why this index is
- #PUC if this returns the entire MorseAccountState that was uploaded.
| } | ||
|
|
||
| message QueryGetMorseAccountStateRequest {} |
| message MsgUpdateParamsResponse {} | ||
|
|
||
| message MsgCreateMorseAccountState { |
There was a problem hiding this comment.
Reminder to add comments everywhere.
It's fine if it's AI generated assuming you review/update after.
Keep it concise but clear.
| message MsgCreateMorseAccountStateResponse { | ||
| bytes state_hash = 1 [(gogoproto.jsontag) = "state_hash"]; | ||
| uint64 num_accounts = 2 [(gogoproto.jsontag) = "num_accounts"]; |
There was a problem hiding this comment.
Not clear what kind of accounts these are.
- Nodes/Suppliers?
- Applications?
- Validators?
- Just token holders?
Consider adding TODOs if we're going to expand it
There was a problem hiding this comment.
Will #PUC, but I've been extremely consistent in my phrasing, which I've been careful to keep consitent with tendermint/comet/cosmos conventions. Account only refers to one on-chain concept, which encapsulates a token balance and a public key. While the concrete representation differs from tendermint to cosmos (and cosmos further isolates balance from public keys internally), this conceptualization is sufficient and consistent, in my view.
| } | ||
|
|
||
| message MsgCreateMorseAccountStateResponse { |
| "github.com/pokt-network/poktroll/x/migration/types" | ||
| ) | ||
|
|
||
| func (k Keeper) MorseAccountState(goCtx context.Context, req *types.QueryGetMorseAccountStateRequest) (*types.QueryGetMorseAccountStateResponse, error) { |
There was a problem hiding this comment.
Consider adding a req.ValidateBasic() like we do in other parts of the code.
|
|
||
| val, found := k.GetMorseAccountState(ctx) | ||
| if !found { | ||
| return nil, status.Error(codes.NotFound, "not found") |
There was a problem hiding this comment.
Can we do some logging here as well?
| @@ -0,0 +1,48 @@ | |||
| package keeper_test | |||
There was a problem hiding this comment.
NOTE: I'm skiping reviewing unit tests in leu of time.
| } | ||
| } | ||
|
|
||
| func (msg *MsgCreateMorseAccountState) ValidateBasic() error { |
There was a problem hiding this comment.
Do we not need to validate morseAccountState?
| message QueryGetMorseAccountStateRequest {} | ||
|
|
||
| message QueryGetMorseAccountStateResponse { |
There was a problem hiding this comment.
E2E test for this? Doesn't have to be in this PR.
There was a problem hiding this comment.
We have unit/integration coverage over this.
Summary
Scaffolds the on-chain
MorseAccountStatesingle as well as a create message/query handlers. Supersedes #1035.Changes:
Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI