Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clients/issues: fix 404 on issue pages #4979

Merged
merged 2 commits into from
Feb 8, 2025
Merged

clients/issues: fix 404 on issue pages #4979

merged 2 commits into from
Feb 8, 2025
+773 −0

Conversation

emilwidlund
Copy link
Member

@emilwidlund emilwidlund commented Feb 7, 2025 •
edited
Loading

Fixes #4977

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
polar ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 0:22am
polar-sandbox ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2025 0:22am

@emilwidlund emilwidlund enabled auto-merge (rebase) February 7, 2025 23:57
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 8, 2025 •
edited
Loading

📦 Next.js Bundle Analysis for web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/(main)/[organization]/[repo]/page 297.03 KB 451.97 KB 129.13%
/(main)/[organization]/[repo]/layout 286.67 KB 441.61 KB 126.17%
/(main)/[organization]/[repo]/issues/status/page 285.3 KB 440.24 KB 125.78%
/(main)/[organization]/[repo]/issues/(create)/page 250.72 KB 405.65 KB 115.90%

One Hundred Thirty-five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/not-found 12.74 KB 167.67 KB 47.91% (+/- <0.01%)
/_not-found/page 353 B 155.28 KB 44.37% (+/- <0.01%)
/layout 68.52 KB 223.46 KB 63.85% (🟡 +0.03%)
/global-error 10.56 KB 165.49 KB 47.28% (+/- <0.01%)
/checkout/[clientSecret]/confirmation/page 346.11 KB 501.04 KB 143.15% (🟢 -0.03%)
/checkout/[clientSecret]/page 198.83 KB 353.76 KB 101.08% (🟡 +0.01%)
/(main)/oauth2/authorize/page 41.65 KB 196.59 KB 56.17% (+/- <0.01%)
/(main)/layout 38.57 KB 193.5 KB 55.29% (+/- <0.01%)
/(main)/signup/page 97.44 KB 252.38 KB 72.11% (🟡 +0.02%)
/(main)/start/page 13.65 KB 168.58 KB 48.17% (+/- <0.01%)
/(main)/login/page 124.54 KB 279.48 KB 79.85% (🟡 +0.03%)
/(main)/new/page 12.07 KB 167.01 KB 47.72% (🟡 +0.01%)
/(main)/verify-email/page 352 B 155.28 KB 44.37% (🟢 -0.01%)
/(main)/(installation)/github/installation/page 96.08 KB 251.01 KB 71.72% (🟡 +0.02%)
/(main)/(installation)/github/layout 352 B 155.28 KB 44.37% (🟢 -0.01%)
/(main)/(topbar)/error/page 2.6 KB 157.53 KB 45.01% (+/- <0.01%)
/(main)/(topbar)/layout 297.77 KB 452.7 KB 129.34% (🟡 +0.05%)
/(main)/(topbar)/not-found 12.74 KB 167.67 KB 47.91% (+/- <0.01%)
/(main)/[organization]/(header)/products/[productId]/page 165.61 KB 320.54 KB 91.58% (🟡 +0.01%)
/(main)/[organization]/(header)/layout 322.5 KB 477.44 KB 136.41% (🟡 +0.05%)
/(main)/[organization]/(header)/donate/page 13.65 KB 168.58 KB 48.17% (+/- <0.01%)
/(main)/[organization]/(header)/page 224.91 KB 379.84 KB 108.53% (🟡 +0.01%)
/(main)/[organization]/(header)/subscriptions/page 354 B 155.28 KB 44.37% (+/- <0.01%)
/(main)/[organization]/(header)/issues/page 213.47 KB 368.4 KB 105.26% (🟡 +0.14%)
/(main)/[organization]/portal/page 304.7 KB 459.64 KB 131.33% (🟢 -0.11%)
/(main)/[organization]/portal/layout 13.65 KB 168.58 KB 48.17% (+/- <0.01%)
/(main)/backoffice/badge/page 136.63 KB 291.57 KB 83.31% (🟡 +0.01%)
/(main)/backoffice/layout 310.64 KB 465.57 KB 133.02% (🟡 +0.05%)
/(main)/backoffice/issue/[id]/page 146.79 KB 301.72 KB 86.21% (🟡 +0.01%)
/(main)/backoffice/pledges/page 149.05 KB 303.98 KB 86.85% (🟡 +0.02%)
/(main)/backoffice/rebadge/page 43.19 KB 198.12 KB 56.61% (🟡 +0.01%)
/(main)/backoffice/rewards_pending/page 150.89 KB 305.83 KB 87.38% (🟡 +0.01%)
/(main)/dashboard/layout 10.6 KB 165.54 KB 47.30% (+/- <0.01%)
/(main)/backoffice/page 2.6 KB 157.53 KB 45.01% (+/- <0.01%)
/(main)/vision/page 112.02 KB 266.96 KB 76.27% (🟡 +0.01%)
/(main)/vision/layout 354 B 155.28 KB 44.37% (+/- <0.01%)
/(main)/(landing)/page 256.11 KB 411.05 KB 117.44% (🟡 +0.03%)
/(main)/(landing)/layout 172.22 KB 327.15 KB 93.47% (🟡 +0.03%)
/(main)/(topbar)/(backer)/purchases/products/page 179.67 KB 334.6 KB 95.60% (🟡 +0.01%)
/(main)/(topbar)/(backer)/layout 46.02 KB 200.95 KB 57.42% (🟡 +0.01%)
/(main)/(topbar)/(backer)/purchases/products/[id]/page 280.89 KB 435.83 KB 124.52% (🟢 -0.01%)
/(main)/(topbar)/(backer)/purchases/license-keys/page 180.55 KB 335.48 KB 95.85% (🟡 +0.02%)
/(main)/(topbar)/(backer)/purchases/subscriptions/[id]/page 300.91 KB 455.84 KB 130.24% (🟡 +0.15%)
/(main)/(topbar)/(backer)/purchases/page 354 B 155.28 KB 44.37% (+/- <0.01%)
/(main)/(topbar)/(backer)/purchases/subscriptions/page 181.93 KB 336.87 KB 96.25% (🟡 +0.01%)
/(main)/(topbar)/(backer)/settings/page 308.6 KB 463.53 KB 132.44% (🟡 +0.39%)
/(main)/(topbar)/(backer)/purchases/file-downloads/page 268.5 KB 423.44 KB 120.98% (🟡 +0.12%)
/(main)/[organization]/portal/(topbar)/subscriptions/[id]/page 297.62 KB 452.55 KB 129.30% (🟢 -0.11%)
/(main)/[organization]/portal/(topbar)/layout 58.13 KB 213.07 KB 60.88% (+/- <0.01%)
/(main)/[organization]/portal/(topbar)/orders/[id]/page 280.79 KB 435.72 KB 124.49% (🟢 -0.01%)
/(main)/[organization]/portal/(topbar)/request/page 161.04 KB 315.97 KB 90.28% (🟡 +0.02%)
/(main)/[organization]/portal/(topbar)/authenticate/page 165.29 KB 320.23 KB 91.49% (🟡 +0.20%)
/(main)/dashboard/[organization]/storefront/page 464.88 KB 619.81 KB 177.09% (🟢 -0.12%)
/(main)/dashboard/[organization]/layout 139.07 KB 294 KB 84.00% (🟡 +0.01%)
/(main)/dashboard/(create)/create/page 211.24 KB 366.18 KB 104.62% (🟢 -0.13%)
/(main)/dashboard/(create)/layout 353 B 155.28 KB 44.37% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/mitchell-hashimoto-joins-polar-as-an-advisor/page 33.9 KB 188.83 KB 53.95% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/introducing-license-keys/page 34.31 KB 189.24 KB 54.07% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/better-pricing/page 33.9 KB 188.83 KB 53.95% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/introducing-annual-subscriptions/page 34.98 KB 189.92 KB 54.26% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/polar-v1-0-lets-fix-open-source-funding/page 34.55 KB 189.48 KB 54.14% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/upsell-discord-invites/page 35.25 KB 190.19 KB 54.34% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/introducing-digital-products/page 36.59 KB 191.53 KB 54.72% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/page 41.58 KB 196.51 KB 56.15% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/build-saas-with-polar/page 35.04 KB 189.98 KB 54.28% (+/- <0.01%)
/(main)/(landing)/(mdx)/legal/privacy/page 33.9 KB 188.83 KB 53.95% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/updated-payout-model/page 34.32 KB 189.26 KB 54.07% (+/- <0.01%)
/(main)/(landing)/(mdx)/careers/page 33.9 KB 188.83 KB 53.95% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/upsell-private-github-repositories/page 35.51 KB 190.44 KB 54.41% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/github-supports-polar-in-funding-yaml/page 34.34 KB 189.28 KB 54.08% (+/- <0.01%)
/(main)/(landing)/(mdx)/legal/terms/page 33.9 KB 188.83 KB 53.95% (+/- <0.01%)
/(main)/(landing)/(mdx)/blog/(header)/polar-v1-0-lower-fees/page 34.33 KB 189.26 KB 54.08% (+/- <0.01%)
/(main)/(topbar)/(backer)/finance/outgoing/page 239.29 KB 394.22 KB 112.63% (🟡 +0.03%)
/(main)/(topbar)/(backer)/finance/layout 271.19 KB 426.13 KB 121.75% (🟡 +0.05%)
/(main)/(topbar)/(backer)/finance/rewards/page 173.43 KB 328.37 KB 93.82% (🟡 +0.03%)
/(main)/(topbar)/(backer)/finance/incoming/page 290.64 KB 445.57 KB 127.31% (🟡 +0.03%)
/(main)/(topbar)/(backer)/(sidebar)/funding/page 305.24 KB 460.18 KB 131.48% (🟡 +0.07%)
/(main)/(topbar)/(backer)/(sidebar)/layout 194.54 KB 349.47 KB 99.85% (🟡 +0.02%)
/(main)/(topbar)/(backer)/finance/account/page 260.15 KB 415.09 KB 118.60% (🟡 +0.04%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/[...all]/page 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/layout 27.55 KB 182.49 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/analytics/page 339.19 KB 494.13 KB 141.18% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/layout 310.63 KB 465.56 KB 133.02% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/benefits/page 406.39 KB 561.33 KB 160.38% (🟢 -0.08%)
/(main)/dashboard/[organization]/(header)/benefits/license-keys/page 338.09 KB 493.02 KB 140.86% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/(home)/page 384.55 KB 539.49 KB 154.14% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/customers/[id]/page 27.56 KB 182.49 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/customers/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/customers/[id]/page 343.52 KB 498.45 KB 142.41% (🟡 +0.06%)
/(main)/dashboard/[organization]/(header)/customers/page 340.32 KB 495.25 KB 141.50% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/initialize/page 237.53 KB 392.47 KB 112.13% (🟡 +0.02%)
/(main)/dashboard/[organization]/(header)/issues/badge/page 338.46 KB 493.39 KB 140.97% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/issues/organizations/page 313.24 KB 468.17 KB 133.76% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/meters/[id]/edit/page 27.56 KB 182.49 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/meters/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/meters/[id]/edit/page 323.73 KB 478.67 KB 136.76% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/issues/overview/page 354.07 KB 509 KB 145.43% (🟡 +0.03%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/meters/[id]/page 27.56 KB 182.49 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/meters/[id]/page 389.63 KB 544.56 KB 155.59% (🟡 +0.06%)
/(main)/dashboard/[organization]/(header)/members/page 311.56 KB 466.49 KB 133.28% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/meters/new/page 14.27 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/meters/new/page 323.73 KB 478.67 KB 136.76% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/meters/page 336.89 KB 491.82 KB 140.52% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/products/[id]/checkout-links/page 347.18 KB 502.12 KB 143.46% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/products/[id]/page 27.56 KB 182.5 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/products/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/[id]/page 401.9 KB 556.83 KB 159.09% (🟢 -0.10%)
/(main)/dashboard/[organization]/(header)/products/benefits/page 405.92 KB 560.85 KB 160.24% (🟢 -0.08%)
/(main)/dashboard/[organization]/(header)/products/discounts/page 361.14 KB 516.07 KB 147.45% (🟡 +0.04%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/products/new/page 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/products/new/page 443.19 KB 598.13 KB 170.89% (🟢 -0.11%)
/(main)/dashboard/[organization]/(header)/products/page 321.52 KB 476.46 KB 136.13% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/sales/[id]/page 27.56 KB 182.5 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/sales/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/sales/[id]/page 352.5 KB 507.44 KB 144.98% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/sales/subscriptions/page 338.23 KB 493.16 KB 140.90% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/sales/page 341.5 KB 496.43 KB 141.84% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/sales/subscriptions/[id]/page 27.57 KB 182.5 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/sales/subscriptions/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/sales/subscriptions/[id]/page 339.12 KB 494.06 KB 141.16% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/settings/custom-fields/page 345.02 KB 499.96 KB 142.84% (🟡 +0.04%)
/(main)/dashboard/[organization]/(header)/settings/page 348.32 KB 503.25 KB 143.79% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/issues/embed/page 313.21 KB 468.15 KB 133.76% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/page 325.74 KB 480.67 KB 137.34% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/settings/webhooks/endpoints/[id]/page 27.57 KB 182.5 KB 52.14% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/@breadcrumb/settings/layout 14.28 KB 169.21 KB 48.35% (+/- <0.01%)
/(main)/dashboard/[organization]/(header)/settings/webhooks/endpoints/[id]/page 342.54 KB 497.47 KB 142.14% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/finance/incoming/page 275.36 KB 430.29 KB 122.94% (🟡 +0.02%)
/(main)/dashboard/[organization]/(header)/finance/layout 310.64 KB 465.57 KB 133.02% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/finance/outgoing/page 223.57 KB 378.51 KB 108.15% (🟡 +0.01%)
/(main)/dashboard/[organization]/(header)/finance/account/page 244.95 KB 399.89 KB 114.25% (🟡 +0.03%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/rewarded/page 157.88 KB 312.82 KB 89.38% (🟡 +0.02%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/layout 310.64 KB 465.57 KB 133.02% (🟡 +0.05%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/page 158.61 KB 313.54 KB 89.58% (🟡 +0.02%)
/(main)/dashboard/[organization]/(header)/finance/issue-funding/contributors/page 157.89 KB 312.82 KB 89.38% (🟡 +0.02%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@emilwidlund emilwidlund merged commit a0ecbf6 into main Feb 8, 2025
9 of 12 checks passed
@emilwidlund emilwidlund deleted the polish branch February 8, 2025 00:05
@sentry-io Sentry.io
Copy link

sentry-io bot commented Feb 8, 2025

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ ResponseError: Response returned an error code Page Server Component (/(main)/[organization]/[... View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link to funding page of project lost 404
1 participant
@emilwidlund