This repository has been archived by the owner on Mar 3, 2024. It is now read-only.
Бандурин Владислав, ИТМО ФИТиП М33321, Bloom Filter #301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexeyShik
requested review from
ikriushenkov
and removed request for
AlexeyShik
ikriushenkov
approved these changes
Dec 25, 2023
| */ | ||
| public class BitSet { | ||
|
|
||
| private final List<Long> longs; |
There was a problem hiding this comment.
Использовать в BitSet ArrayList<Long> очень плохая затея. Советую посмотреть, как это будет устроено в памяти и окажется, что такая реализация будет сильно проигрывать и по памяти, и по времени хотя бы long[]. Данная реализация теряет весь смысл в использовании битсета вообще
There was a problem hiding this comment.
Посмотрю, спасибо.
По поводу codeclimate - там нужно было менять код в MurMurHash, из-за чего он начинал некорректно работать.
|
Доставил до 4 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.