fix(ExtrinsicPayload): decode assetId with and without option #6037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlosala
force-pushed
the
cs-fix-payload
branch
from
375fd79 to
49f457c
Compare
TarikGul
reviewed
Nov 25, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5968 introduced an unexpected breaking change since, at the moment, the
ExtrinsicPayloadtype can only parse hex assetId with the Option byte. This PR addresses it, making it backwards compatible, and now all ways (hex with and without option, PJS object, and number) are supported.This should fix as well #6032.
I'm truly sorry about the confusion I might have created :(
Thanks!