Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patch typegen query to prevent it from adding invalid import #6073

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

valentinfernandez1
Copy link
Contributor

This PR implements a temporary workaround for issue #5977. Currently, there's a bug where the StagingXcmV4Xcm type is incorrectly assigned in query.rs. While the root cause needs investigation, this PR avoids import errors by temporarily ignoring the type. This allows us to renable "noUnusedLocals": true in tsconfig.json

Note: This is a temporary solution. A proper fix for #5977 should be implemented in a future PR.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Thanks so much

@TarikGul TarikGul merged commit e16ae08 into master Jan 23, 2025
4 checks passed
@TarikGul TarikGul deleted the fix/typegen-invalid-import branch January 23, 2025 15:08
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jan 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants