style(optional artifact): catch the cause for misleading warning

This changes ensures the warning for optional artifacts will only be printed in valid cases.
pollination · Feb 24, 2021 · d7a5c01 · d7a5c01
1 parent b0026ce
commit d7a5c01
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/queenbee/base/basemodel.py b/queenbee/base/basemodel.py
@@ -5,7 +5,7 @@
 
 import yaml
 from pydantic import BaseModel as PydanticBaseModel
-from pydantic import validator, Field, constr, Extra
+from pydantic import validator, Field, constr
 
 from .parser import parse_file
 from .variable import get_ref_variable

diff --git a/queenbee/io/inputs/dag.py b/queenbee/io/inputs/dag.py
@@ -270,7 +270,9 @@ class DAGFolderInput(DAGGenericInput):
     @validator('required', always=True)
     def check_required(cls, v, values):
         """Overwrite check_required fro artifacts to allow optional artifacts."""
-        default = values.get('default', None)
+        if 'default' not in values:
+            return v
+        default = values.get('default')
         name = values.get('name', None)
         if default is None and v is False:
             warnings.warn(