Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: endpoints readme #147

Closed
wants to merge 1 commit into from
Closed

Conversation

victorforissier
Copy link
Contributor

No description provided.

@lowczarc
Copy link
Contributor

lowczarc commented Sep 4, 2024

I suppose (and hope) it's generated with GPT/Claude.

It's basically all garbage. I didn't check everything in detail but by looking at it 2s:
The authentification is done with X-Access-Token, not with authorization
Generate uses the task parameter, not input.
STT needs to be send a file path of a file previously uploaded on supabase and not a base64 of the file.
The error handling part is basically useless since it just explain the HTTP error status and doesn't give any of the error we are actually sending.

I don't think it's worth to add doc if we're deprecating it anyway

Copy link
Contributor

@lowczarc lowczarc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No doc is better than fake doc

@victorforissier
Copy link
Contributor Author

Yeah it's Sonnet 3.5 I thought it'd just take the endpoint ref and didn't double check.
All the doc archive is in the SDK repo now we can forget that.

@lowczarc
Copy link
Contributor

lowczarc commented Sep 4, 2024

I'm closing then

@lowczarc lowczarc closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants