Primitive voice implementation (feature/voice) #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
requested changes
Apr 16, 2024
Co-authored-by: Flori <[email protected]>
Co-authored-by: Flori <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
bitfl0wer
approved these changes
Apr 16, 2024
bitfl0wer
reviewed
Apr 16, 2024
bitfl0wer
added a commit
that referenced
this pull request
Apr 16, 2024
## Release 0.15.0 ### TODO: - [x] Merge #457 - [x] Merge #489 ## Changes - Primitive voice support: #457 - Cleaner code - Replace `Arc<RwLock<T>>` with `Shared<T>`: #466 - More, better documentation - More tests - Fix some typos - Make gateway `close()` code cleaner - Remove `#[derive(Eq)]` from types which falsely had this trait derived - Change license from AGPL-3 to MPL-2.0: #477 - Bump `whoami`, `mio`, `h2` to fix CVEs - Bump versions of used GitHub Actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(opening this into a pr to track changes, progress, todos and merge conflicts)
This pr (when complete) aims to add voice channel and call support to Chorus via Discord's UDP api.
Current todo:
Features:
Docs:
Compatibility:
UDP WASM compatibility- the browser cannot do udp.Code quality:
UDP vs Webrtc
User accounts sometimes use an undocumented Webrtc api for voice and video, while bots use the documented UDP api.
I've decided to implement the UDP api for now, since Webrtc is much more complex and less documented.
We may want to look into Webrtc aswell in the future.
Architecture and public API
My current plan is to have four parts of the impl: the Voice Gateway, voice UDP, Voice Data and Voice Handler
The user can then interact with the Voice Gateway to issue gateway commands and receive voice context.
The voice UDP handler would expose a slightly higher level api, with listener events for decrypted and deserialized audio as well as a method which serializes, encrypts and sends audio.