Client properties API #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most routes created somewhat recently use ChorusRequest {}, and the new .with methods favor that approach.
|
This looks really ergonomic upon first glance. Well done! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new approach to client properties from #584
Each
ChorusUsernow has its ownClientPropertiesstruct, which contains telemetry data sent when identifying with the gateway and with every request to the HTTP API.This also means every request includes three new headers:
X-Super-Properties(the entireClientPropertiesencoded in base 64),X-Discord-Locale(which is copied fromClientProperties.system_locale) andX-Debug-Options(which is set to a hard-coded value ofbugReporterEnabled)Internally this also removes the old api
ChorusRequest::newin favor ofChorusRequest {}, along with refactoring how headers are set on all routes