Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile UI #320

Merged
merged 241 commits into from
Aug 10, 2024
Merged

Profile UI #320

merged 241 commits into from
Aug 10, 2024

Conversation

dhruv8433
Copy link
Contributor

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

@pooranjoyb

[Feature] Ui for Profile Page #269

Fixes #269 (issue)

Type of change

Please give a X on it which is applicable

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactor Code
  • A documentation update
  • Others(mentioned in the issue number)

How Has This Been Tested?

go to /profile route

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Test A Describe here

Test B Describe here (if Requred)

Screenshots and Videos:

image

image

image

image

Give screenshots and video of the changes you made

Checklist:

Give a X on, which is applicable

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

dhruv8433 and others added 30 commits June 5, 2024 09:17
commit 7eae5f7
Author: yashi-15 <[email protected]>
Date:   Sat Jun 8 11:11:37 2024 +0530

    responsiveness

commit 65f8ca6
Author: yashi-15 <[email protected]>
Date:   Wed Jun 5 23:38:19 2024 +0530

    footer links changes

commit bbad055
Author: yashi-15 <[email protected]>
Date:   Wed Jun 5 23:31:42 2024 +0530

    mobile responsive

commit d3867c7
Author: yashi-15 <[email protected]>
Date:   Wed Jun 5 22:00:50 2024 +0530

    UI updated
* UI updated

* mobile responsive

* footer links changes

* responsiveness

Co-authored-by: Mahima <[email protected]>
Co-authored-by: Pooranjoy Bhattacharya <[email protected]>
@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please merge it before gssoc end
and it also creates conflicts

please merge it

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

Please merge it before gssoc end
I think it's 30 jul ...

@pooranjoyb
Copy link
Owner

@pooranjoyb

Please merge it before gssoc end I think it's 30 jul ...

Yes, actually had a discussion with the mentors, this one actually didn't get approved properly as this doesnot look that good uk. Still i will merge this in different branch tho :)

@pooranjoyb pooranjoyb changed the base branch from dev to won't-fix July 26, 2024 15:03
@pooranjoyb pooranjoyb changed the base branch from won't-fix to test July 26, 2024 15:04
@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please tell me if you need any changes
please merge it .... :/

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

please sir response
today is last day and you told me that you can merge this pr

please sir check into this

@dhruv8433
Copy link
Contributor Author

@pooranjoyb

i resolve all conflicts now please merge this into any other branch

@pooranjoyb pooranjoyb merged commit ab9efe1 into pooranjoyb:test Aug 10, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc Girlscript Summer of Code 2024 level2 Issues with difficulity level 2 ui Improvements of User Interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Ui for Profile Page