-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Super + Right Click to open window context menu #1118
base: master
Are you sure you want to change the base?
Conversation
I was, in fact, missing something. |
This could be solved by adding a little bit of tolerance before considering a move significant enough to trigger the resize behaviour. E.g. something like "more then 10 display units in any axis". Which would still be the preferred solution to this problem. |
Is there a general setting/recommended value for tolerance or is it just ad-hoc? It's a fine line to tread in my experience for these arbitrary values. I'm fine with changing the behaviour to something that could debatably be more intuitive, but I'd prefer to stay on the side of unambiguity. |
I don't think we have this problem in another part of cosmic-comp yet, so no. The exact value here would need to be "felt out". Just add a constant with an arbitrary value you feel that work well and we will tweak it from there.
I personally have nothing against providing an unambiguous trigger additionally, but any changes to the agreed upon solution in #909 would need to go through @pop-os/ux. |
Alright, I've removed the Middle click and Shift + Right click shortcuts in lieu of just the right click, and added a customizable radius for checking whether the mouse cursor has moved. |
d9e82c7
to
532f477
Compare
This PR fixes #909
Using Super + Right-click without moving the cursor opens the window context menu at the cursors location. The radius for determining if a pointer hasn't moved is customizable.