Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run cargo update #1130

Closed
wants to merge 2 commits into from
Closed

Run cargo update #1130

wants to merge 2 commits into from

Conversation

ids1024
Copy link
Member

@ids1024 ids1024 commented Jan 10, 2025

Used cargo update -p [email protected] --precise 0.5.9 to ensure it still builds on Rust 1.80.0.

This includes pop-os/cosmic-text@166b59f, which is probably beneficial to cosmic-comp as well. May as well also update other dependencies, and just after an alpha release seems as good a time as any to do so.

@ids1024 ids1024 requested a review from a team January 10, 2025 22:50
@ids1024
Copy link
Member Author

ids1024 commented Jan 10, 2025

Hm, not sure Jenkins is failing.

cargo build --release --offline --locked
warning: `/<<PKGBUILDDIR>>/.cargo/config` is deprecated in favor of `config.toml`
note: if you need to support cargo 1.38 or earlier, you can symlink `config` to `config.toml`
error: failed to load source for dependency `smithay`

Caused by:
  Unable to update https://github.com/smithay//smithay?rev=9fbc9fb#9fbc9fbb

Caused by:
  can't checkout from 'https://github.com/smithay//smithay': you are in the offline mode (--offline)
make[1]: *** [Makefile:30: all] Error 101
make[1]: Leaving directory '/<<PKGBUILDDIR>>'
dh_auto_build: error: make -j128 returned exit code 2
make: *** [debian/rules:8: build-arch] Error 25
dpkg-buildpackage: error: debian/rules build-arch subprocess returned exit status 2

That shouldn't really have changed. I guess this is an issue where cargo doesn't produce a useful message...

@ids1024
Copy link
Member Author

ids1024 commented Jan 10, 2025

Ah. So cargo vendor | head -n -1 > .cargo/config returns 0 even if cargo vendor failed, so the source build produced an error, but was treated as success.

Used `cargo update -p [email protected] --precise 0.5.9` to ensure it still
builds on Rust 1.80.0.
@Drakulix
Copy link
Member

Merged manually

@Drakulix Drakulix closed this Jan 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants