Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libcosmic/iced #618

Merged
merged 10 commits into from
Oct 22, 2024
Merged

Update libcosmic/iced #618

merged 10 commits into from
Oct 22, 2024

Conversation

jackpot51
Copy link
Member

No description provided.

@jackpot51 jackpot51 marked this pull request as draft October 21, 2024 20:18
@jackpot51 jackpot51 marked this pull request as ready for review October 21, 2024 20:50
@jackpot51 jackpot51 requested review from a team October 21, 2024 20:50
@hojjatabdollahi
Copy link

Not a big deal but images in gallery mode are not centered.

@jackpot51
Copy link
Member Author

@hojjatabdollahi Thanks, I will fix that.

@git-f0x
Copy link
Contributor

git-f0x commented Oct 21, 2024

Possibly unrelated (I tested this, then reinstalled cosmic-files, with the same behavior), but show details on the desktop doesn't seem to work (causes a panic in cosmic-files-applet).
Edit: Rectangle selection on the desktop causes very high CPU usage by cosmic-files-applet with this PR.

@wash2
Copy link
Contributor

wash2 commented Oct 22, 2024

Edit: Rectangle selection on the desktop causes very high CPU usage by cosmic-files-applet with this PR.

Should be fixed by pop-os/iced#180

@jackpot51 jackpot51 merged commit 2ae97c1 into master Oct 22, 2024
@jackpot51 jackpot51 deleted the libcosmic-rebase branch October 22, 2024 14:22
@git-f0x
Copy link
Contributor

git-f0x commented Oct 22, 2024

Not sure if this will be seen, but image thumbnails also aren't centered (in grid/list view, and desktop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants