Rebase multi window #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash2
force-pushed
the
rebase-multi-window
branch
5 times, most recently
from
163eb0f to
56b6d65
Compare
mmstick
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds our changes on top of multi-window support. I had to keep
UserEventWrapperfor use withaccesskit_winit. Window Id creation has changed and is behind a function that increments a counter. And non-multi-window apps always exit on close now as well. I still need to make changes to libcosmic, but the examples here seem to be working and I cleaned up some of our commits as well. The initial a11y commit examples should build as well as the initial sctk examples.