Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Update to 0.12 #228

Merged
merged 10 commits into from
Dec 4, 2023
Merged

WIP: Update to 0.12 #228

merged 10 commits into from
Dec 4, 2023

Conversation

wash2
Copy link
Contributor

@wash2 wash2 commented Nov 30, 2023

cosmic-time still needs to be updated. Most of libcosmic is working well now, but I'm still looking into a small layout issue for dropdown menu items, and also a color picker tooltip. It panics when interacting with the tooltip after interacting with the color picker previously.

@wash2 wash2 force-pushed the update-0.12 branch 3 times, most recently from 1cf4a1b to ff73a92 Compare November 30, 2023 19:02
@wash2
Copy link
Contributor Author

wash2 commented Nov 30, 2023

Everything seems to be working alright now, so this should be ready for review.
I will start updating some applications and applets to see if we need any more changes too.

pop-os/iced#85
pop-os/cosmic-time#17

@wash2 wash2 requested a review from a team November 30, 2023 20:24
@wash2
Copy link
Contributor Author

wash2 commented Nov 30, 2023 •
edited
Loading

The launcher window is very small when testing. (fixed by latest iced)

@wash2 wash2 force-pushed the update-0.12 branch 9 times, most recently from 15bde0c to ee9118a Compare December 4, 2023 18:33
@wash2 wash2 marked this pull request as ready for review December 4, 2023 21:50
@wash2 wash2 mentioned this pull request Dec 4, 2023
Closed
@mmstick
Copy link
Member

mmstick commented Dec 4, 2023

Seems fine. There is one change that I noticed in the design demo. The width of the debug toggle, using cosmic-time's toggler, now defaults to Length::Shrink rather than Length::Fill now.

@wash2
Copy link
Contributor Author

wash2 commented Dec 4, 2023

Seems fine. There is one change that I noticed in the design demo. The width of the debug toggle, using cosmic-time's toggler, now defaults to Length::Shrink rather than Length::Fill now.

Ok, should I change that? I had to change the method for the layout of the toggler in cosmic-time, which is probably what causes the difference.

@mmstick
Copy link
Member

mmstick commented Dec 4, 2023

We can adjust it in the design-demo

@wash2 wash2 merged commit cda781c into master Dec 4, 2023
9 checks passed
@mmstick mmstick deleted the update-0.12 branch January 10, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmstick mmstick mmstick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wash2 @mmstick @wiiznokes