WIP update keymap based on keymap from server #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix for #8, though due to #10, changes to the selected layout group aren't forwarded from the server. Requires Smithay/client-toolkit#299 and Smithay/smithay#750. I believe this results in unregistering the `wl_keyboard` and creating a new one. Having a way in smithay to alter the existing `wl_keyboard` may work better. The above PRs also have soundness issues due to the non-thread-safe ref-counting in xdgcommon, and how smithay/sctk assume they hold the only references.
|
Oh, I guess "removing" the keyboard here is just sending a change to the seat capabilities, and previously created So I think that part should be fine, and it's just the mess with libxkbcommon and threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #8, though due to #10, changes to the selected layout group aren't forwarded from the server.
Requires Smithay/client-toolkit#299 and Smithay/smithay#750.
I believe this results in unregistering the
wl_keyboardand creating a new one. Having a way in smithay to alter the existingwl_keyboardmay work better.The above PRs also have soundness issues due to the non-thread-safe ref-counting in xdgcommon, and how smithay/sctk assume they hold the only references.