-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A bunch of minor changes to the json schema snippets. #20
Open
vineshtv
wants to merge
2
commits into
main
Choose a base branch
from
json_schema_snippets
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vineshtv
commented
Feb 3, 2023
- Fixed some prefixes which were named incorrectly.
- Fixed the description for some fields which were incorrect.
- Added a description field to all properties.
- Added the prefix 'Snowboard: ' to the snippet name so that it shows up in dropdown.
- Added more prefixes for nullable parameters.
- Updated some tabstops.
1. Fixed some shortcuts which were named incorrectly. 2. Fixed the description for some fields which were incorrect. 3. Added a description field to all properties. 4. Added the prefix 'Snowboard: ' to the snippet name so that it shows up in dropdown. 5. Added more prefixes for nullable parameters. 6. Updated some tabstops.
jethron
approved these changes
Feb 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great changes! Should be a good improvement.
- Should we both with filling
title
with the value of${1}
? - Is it worth including an "Add enum property" and "Add const property" for completion?
vineshtv
commented
Feb 3, 2023
"description": "An array of booleans" | ||
"Snowboard: Array of arrays property": { | ||
"prefix": ["array of arrays"], | ||
"body": ["\"${1:property_name}\": {", "\t\"type\": \"array\",", "\t\"description\": \"${2:Description of ${1} goes here}\",", "\t\"items\": {", "\t\t\"type\": \"array\",", "\t\t\"description\": \"${3:Description goes here}\",", "\t\t\"items\": {", "\t\t\t\"type\": \"${4|number,integer,string,boolean,array,object|}\",", "\t\t\t\"description\": \"${5:Description goes here}\"", "\t\t}", "\t}", "}${0}"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So now it adds the snippet like so -
"property_name": {
"type": "array",
"description": "Description of property_name goes here",
"items": {
"type": "array",
"description": "Description goes here",
"items": {
"type": "number",
"description": "Description goes here"
}
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.