Use startup_file to force a standardized repos option during testing
#650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Technically `wasm` is another valid option here)
DavisVaughan
commented
Dec 3, 2024
| #[cfg(windows)] | ||
| #[cfg(not(unix))] |
There was a problem hiding this comment.
I also tweaked this because we use #[cfg(unix)] above, so it seems cleanest to use not(unix) to ensure we dont miss anything
Comment on lines
+50
to
+61
| assert_eq!(frontend.recv_shell_execute_reply(), input.execution_count); | ||
|
|
||
| let code = r#"getOption("repos")[["Internal"]]"#; | ||
| frontend.send_execute_request(code, ExecuteRequestOptions::default()); | ||
| frontend.recv_iopub_busy(); | ||
|
|
||
| let input = frontend.recv_iopub_execute_input(); | ||
| assert_eq!(input.code, code); | ||
| assert_eq!( | ||
| frontend.recv_iopub_execute_result(), | ||
| r#"[1] "https://internal.cran.mirror/""# | ||
| ); |
There was a problem hiding this comment.
Added testing for the Internal repo too to make sure it gets set
jmcphers
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
LGTM, thanks for this!
Confirmed tests pass locally with this change, too.
running 1 test
test test_auto_repos ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.42s
Running tests/repos-conf-file.rs (target/debug/deps/repos_conf_file-eca1d963ef415763)
running 1 test
test test_conf_file_repos ... ok
test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.43s
| #[cfg(windows)] | ||
| #[cfg(not(unix))] |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because r-lib/rig#203 forces a non-
@CRAN@default for myCRANrepo, meaning that the tests don't pass for me locally becauseapply_repo_defaults()sees that something is set and doesn't override it.