Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Explorer: Return empty string in schema response instead of [, i] for empty column name #659

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

wesm
Copy link
Contributor

@wesm wesm commented Jan 3, 2025

Per discussion in posit-dev/positron#3084, with code like

example <- data.frame(1:10, 1:10, 1:10)
names(example) <- c("", "age", "age ")

We have decided for now to return the column names as is, even if they are empty, and let the UI decide how to render them. With this change, we now see:

image

@wesm wesm merged commit 68de61c into main Jan 6, 2025
6 checks passed
@wesm wesm deleted the feature/de-empty-column-names branch January 6, 2025 18:39
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant