Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(brand): Apply monospace-inline and monospace-block font family #1762

Merged
merged 2 commits into from
Nov 7, 2024

Conversation

gadenbuie
Copy link
Collaborator

@gadenbuie gadenbuie commented Nov 6, 2024

Fixes #1761

I mapped the typography.monospace-inline.family and typography.monospace-block.family values to Sass variables (font-family-monospace-inline and font-family-monospace-block, using the same naming as Quarto), but forgot to apply these in CSS rules.

While here, I updated the monospace inline rules to better catch "inline" code, i.e. code:not(pre > code) instead of just code.

The example in #1761 works with this change, as well as using different values for inline and block, e.g.

typography:
  monospace-inline:
    family: Arial

@gadenbuie gadenbuie marked this pull request as ready for review November 6, 2024 20:18
@gadenbuie gadenbuie merged commit a35f3a8 into main Nov 7, 2024
47 checks passed
@gadenbuie gadenbuie deleted the fix/1761-theme-brand-monospace-font-family branch November 7, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Brand.yml doesn't follow the overriding font families in monospace-block and monospace-inline
2 participants