Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiplatform build #405

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

niccokunzmann
Copy link

@niccokunzmann niccokunzmann commented Feb 5, 2025

This makes a start at fixing #216.

Changes:

  • Add buildx option to Makefile
  • Add buildx install to github action
  • Add PLATFORMS variable to github actions
  • Document building with make in README

I will check the platforms now...

@niccokunzmann
Copy link
Author

The alpine build works.

@ImreSamu
Copy link
Member

ImreSamu commented Feb 5, 2025

Thank you for the PR.

When I tested the QEMU solution some time ago, I ran into a few emulation issues.
Because of that, I am much more cautious with this technique.
However, I might need to re-evaluate some things since then.
#393 (comment)

@niccokunzmann
Copy link
Author

niccokunzmann commented Feb 5, 2025

@ImreSamu Thanks for the link, I had a look at your PR. You seem to be well versed in what to change in the Docker files. I do not know that so much...

Since #216 mentions this: #216 (comment)
It seems builds are already been done. I wonder why alpine builds work but buster builds do not under arm64 for this configuration I have here... Official alpine images would be a start or adding a link to the other Repository mentioned here in the README. I can check more about why the buster build fails...

@niccokunzmann
Copy link
Author

niccokunzmann commented Feb 6, 2025

This now only adds the buildx possibility to build the image for another platform. The CI is not affected. I will create a new PR for the CI.

Reason: #216 (comment)

@niccokunzmann niccokunzmann mentioned this pull request Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants