This repository has been archived by the owner on Jul 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 34
Generate Secrets with Kubernetes API #204
Draft
versilis
wants to merge
22
commits into
main
Choose a base branch
from
versilis/kube-secret-with-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: versilis <[email protected]>
Signed-off-by: versilis <[email protected]>
Signed-off-by: versilis <[email protected]>
Signed-off-by: versilis <[email protected]>
Co-authored-by: Mark Gritter <[email protected]>
This provides a workaround to remove all telemetry info logs during a command's initialization. This is needed by the kube secret command because only the raw YAML output should be printed to stdout.
versilis
force-pushed
the
versilis/kube-secret-with-api
branch
2 times, most recently
from
March 21, 2023 15:53
83aaf74
to
64f0125
Compare
versilis
force-pushed
the
versilis/kube-secret-with-api
branch
from
March 21, 2023 16:23
64f0125
to
3d5e896
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses a code review suggestion to use the Kubernetes API for generation of secret files when using
akita kube secret
.Unfortunately, Kubernetes' current Go API contains an
ObjectMeta
model that is in misalignment with Kubernetes' open api spec. As a workaround, I've added logic to manually fix the incorrect field (CreationTimestamp
) after serialization.