Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace traverse with neotraverse. #815

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Conversation

VShingala
Copy link
Member

@VShingala VShingala commented Jul 22, 2024

This PR is copy of #806.

Note: This PR requires Node v18 support first. (This is resolved with latest version)

This PR replaces traverse with neotraverse, a fork and TypeScript rewrite of traverse with 0 dependencies (as opposed to 66: https://npmgraph.js.org/?q=traverse) and lots of improvements.

@VShingala VShingala changed the title Replace traverse with neotraverse. [Node18+] Replace traverse with neotraverse. Jul 22, 2024
@PuruVJ
Copy link

PuruVJ commented Jul 22, 2024

Note: This PR requires Node v18 support first.

It doesn't! Check out my comment on the previous PR 😄

package.json Outdated
@@ -124,13 +124,13 @@
"js-yaml": "4.1.0",
"json-schema-merge-allof": "0.8.1",
"lodash": "4.17.21",
"neotraverse": "0.6.14",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be 0.6.15

@VShingala
Copy link
Member Author

@PuruVJ Nice! That was super quick support. I'll update the PR with the latest version and merge it accordingly.

@VShingala VShingala changed the title [Node18+] Replace traverse with neotraverse. Replace traverse with neotraverse. Jul 22, 2024
@VShingala VShingala merged commit 34f299e into develop Jul 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants