[PBNTR-456] Fixed Confirmation Toast - Enable "auto close" for RAILS #4179
Conversation
ElisaShapiro
added
milano
|
A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-456-fixed-conf-toast-rails-autoclose |
|
Hey @ElisaShapiro , code looks good, but when you first navigate to the Rails side of the fixed confirmation toast, the toast for 'I will close in 10s' is already on the page for a second before it disappears. Not sure if this is kit level issue or a doc script tag issue |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR456fixedconftoastrailsautoclose5673 Your Alpha for NPM is 14.12.0-alpha.PBNTR456fixedconftoastrailsautoclose5673 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR456fixedconftoastrailsautoclose5728 Your Alpha for NPM is 14.12.0-alpha.PBNTR456fixedconftoastrailsautoclose5728 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR456fixedconftoastrailsautoclose5738 Your Alpha for NPM is 14.12.0-alpha.PBNTR456fixedconftoastrailsautoclose5738 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR456fixedconftoastrailsautoclose5754 Your Alpha for NPM is 14.12.0-alpha.PBNTR456fixedconftoastrailsautoclose5754 |
|
🎉 Congratulations on creating an Alpha Version! Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR456fixedconftoastrailsautoclose5757 Your Alpha for NPM is 14.12.0-alpha.PBNTR456fixedconftoastrailsautoclose5757 |
|
You merged this pr to master branch: |
What does this PR do? A clear and concise description with your runway ticket url.
PBNTR-456 requested creation of an
auto_closeprop for the Rails Fixed Confirmation Toast; investigation revealed that PBNTR-475 actually created both React and Rails versions of the prop, but only displayed a doc example for the React side. It is already being used in Nitro in a few places see here.This PR adds the rails doc example and updates the PbEnhancedElement file to ensure autoclosing works as expected for standard and closeable (has X to close) toasts. An initial overhaul of the PbEnhancedElement was too much and failed alpha testing (which revealed that the previously only closeable autoclose fixed confirmation toasts worked in nitro at all) - this PR contains a minimally updated version that works for both closeable and default autoclose toasts in rails.
Screenshots: Screenshots to visualize your addition/change
How to test? Steps to confirm the desired behavior:
Checklist:
enhancement,bug,improvement,new kit,deprecated, orbreaking. See Changelog & Labels for details.milanolabel to show I'm ready for a review.