Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1501] Enable Lightweight User Names in User Kit #4194

Merged
merged 7 commits into from
Jan 31, 2025
Merged

[PLAY-1501] Enable Lightweight User Names in User Kit #4194

merged 7 commits into from
Jan 31, 2025

Conversation

cmhorsey
Copy link
Contributor

What does this PR do? A clear and concise description with your runway ticket url.
Allows user to set user names in User kit to lightweight.

Story 1501
Screenshots: Screenshots to visualize your addition/change
Rails:
Screenshot 2025-01-29 at 3 33 00 PM

React:
Screenshot 2025-01-29 at 3 33 53 PM

How to test? Steps to confirm the desired behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See addition/change

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@cmhorsey cmhorsey added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Jan 29, 2025
@cmhorsey cmhorsey self-assigned this Jan 29, 2025
@cmhorsey cmhorsey requested a review from a team as a code owner January 29, 2025 21:20
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=play-1501-enable-lightweight-user-names

@nidaqg nidaqg added Code Approved Approved by a Playbook Admin Inactive RC Skip the release candidate process Ready for Release merged to master, ready for a versioned released Product Approved pending technical review, OK to merge to master and removed Needs Review labels Jan 31, 2025
@nidaqg nidaqg merged commit 6eb08db into master Jan 31, 2025
16 checks passed
@nidaqg nidaqg deleted the play-1501-enable-lightweight-user-names branch January 31, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nidaqg nidaqg nidaqg approved these changes

Assignees

@cmhorsey cmhorsey

Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target Product Approved pending technical review, OK to merge to master Ready for Release merged to master, ready for a versioned released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmhorsey @nidaqg