Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PLAY-1761] Copy Kit - Create Icon Variant in React #4205

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

[PLAY-1761] Copy Kit - Create Icon Variant in React #4205

wants to merge 5 commits into from

Conversation

gabbymassaro
Copy link
Contributor

@gabbymassaro gabbymassaro commented Jan 30, 2025 •
edited
Loading

What does this PR do? A clear and concise description with your runway ticket url.
PLAY-1761
Create a new "Icon Button" variant
Create a new "Icon Button" doc example

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-01-31 at 11 27 46 AM

How to test? Steps to confirm the desired behavior:

  1. Go to /kits/copy_button/react
  2. Scroll down to Copy Icon doc example
  3. See new doc example, copy button works as expected

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@gabbymassaro gabbymassaro self-assigned this Jan 30, 2025
@gabbymassaro gabbymassaro added minor Semver Target enhancement New Features, Props, & Variants (USED IN CHANGELOG) labels Jan 31, 2025
@gabbymassaro gabbymassaro marked this pull request as ready for review January 31, 2025 16:28
@gabbymassaro gabbymassaro requested a review from a team as a code owner January 31, 2025 16:28
@gabbymassaro gabbymassaro added the milano 20 MAX - Deploy this PR to a review environment via Milano label Jan 31, 2025
kangaree
kangaree reviewed Jan 31, 2025
View reviewed changes
Copy link
Contributor

@kangaree kangaree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just have some small comments.

playbook/app/pb_kits/playbook/pb_copy_button/docs/_copy_button_icon.jsx Show resolved Hide resolved
playbook/app/pb_kits/playbook/pb_copy_button/_copy_button.tsx Show resolved Hide resolved
@gabbymassaro gabbymassaro removed the milano 20 MAX - Deploy this PR to a review environment via Milano label Feb 4, 2025
@gabbymassaro gabbymassaro marked this pull request as draft February 4, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kangaree kangaree kangaree left review comments

@nidaqg nidaqg nidaqg left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@gabbymassaro gabbymassaro

Labels
enhancement New Features, Props, & Variants (USED IN CHANGELOG) minor Semver Target
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabbymassaro @kangaree @nidaqg