Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBNTR-779 | Draggable kit: Add the "cross-container" functionality to RAILS kit #4210

Merged
merged 6 commits into from
Feb 6, 2025

Conversation

skduncan
Copy link
Contributor

@skduncan skduncan commented Jan 31, 2025

What does this PR do? A clear and concise description with your runway ticket url.
As a Playbook dev,
I want to implement the "cross container" functionality to our Rails Draggable kit,
so that I can ensure parity between my Rails and React Draggable kits.

Screenshots: Screenshots to visualize your addition/change
Screenshot 2025-01-31 at 2 56 29 PM

How to test? Steps to confirm the desired behavior:

  1. Go to 'Dragging Across Multiple Containers' doc example

Checklist:

  • LABELS Add a label: enhancement, bug, improvement, new kit, deprecated, or breaking. See Changelog & Labels for details.
  • DEPLOY I have added the milano label to show I'm ready for a review.
  • TESTS I have added test coverage to my code.

@skduncan skduncan added enhancement New Features, Props, & Variants (USED IN CHANGELOG) milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target labels Jan 31, 2025
@skduncan skduncan requested a review from a team as a code owner January 31, 2025 20:56
@powerhome-portal
Copy link

A change to documentation files was detected in your PR. Please visit this link to preview changes: https://portal-staging.powerapp.cloud/docs?filters[kind]=all&filters[user]=all&filters[namespaceFilter]=pbntr-779railsdraggablecrosscontainer

@skduncan skduncan changed the title Added multiple container drag functionality to rails kit PBNTR-779 | Draggable kit: Add the "cross-container" functionality to RAILS kit Jan 31, 2025
nidaqg
nidaqg previously approved these changes Feb 3, 2025
@nidaqg nidaqg added the Code Approved Approved by a Playbook Admin label Feb 3, 2025
Copy link

github-actions bot commented Feb 3, 2025

🎉 Congratulations on creating an Alpha Version!

Your Alpha for Ruby Gems is 14.12.0.pre.alpha.PBNTR779railsdraggablecrosscontainer5863

Your Alpha for NPM is 14.12.0-alpha.PBNTR779railsdraggablecrosscontainer5863

@skduncan skduncan added the Inactive RC Skip the release candidate process label Feb 6, 2025
@skduncan skduncan merged commit d447baa into master Feb 6, 2025
9 checks passed
@skduncan skduncan deleted the PBNTR-779_rails_draggable_cross_container branch February 6, 2025 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Approved Approved by a Playbook Admin enhancement New Features, Props, & Variants (USED IN CHANGELOG) Inactive RC Skip the release candidate process milano 20 MAX - Deploy this PR to a review environment via Milano minor Semver Target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants