-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: OP-sqlite write transaction single operation notification #461
Conversation
…ocessed. Batching update notifications per write lock.
🦋 Changeset detectedLatest commit: 8441600 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good.
I assume this would also affect regular watched queries?
Using It does improve watched queries and the reactive query hooks. |
I mean that if you had |
Correct - sorry I misunderstood. Updated the changeset entry to mention this. |
This PR addresses a timing issue in OPsqlite where the SQLite update hook triggers before the commit completes when performing single-write transactions (Resulting in
ps_crud
not being processed). As a result,nextCrudItem
was returning undefined because the data was not yet committed at the time the hook fired.Using
react-native-quick-sqlite
as reference, updates are now batched and only flushed after a write lock is released.