Json wifi structure update; password is saved on succesfull connection only #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wifi:[{s1:p1},{s2:p2}]
to
wifi:{s1:p1,s2:p2}
- wifi password is now saved only upon succesfull connection
Nolven
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
wifi:[{s1:p1},{s2:p2}]
to
wifi:{s1:p1,s2:p2}
So refactoring + bug fixing + improvement
Why
O(1) instead of O(n) to find a wifi password
Code is cleaner
Bug fixed (:
Verification
Try to connect to a known wifi with the wrong password
Retry with the correct password
Disconnect from the wifi
Connect to it again. Check that the password type pop-up didn't appear and it used the stored password
(previously the password was saved on the first connection attempt rather than the successful one)
User-Facing Change
Users should clean the Wi-Fi section of the config file (or just remake the config file) otherwise the passwords won't be saved
Further Comments
This one is a preparation for a wifi repeater functionality