-
-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T-Embed-CC1101] Encoder RGB LED Support #563
Conversation
Im opening this up for merge since it provides original functionality. This is not a complete feature and will still be tracked in #562 with further pull requests. |
This does function as intended on the T-Embed-CC1101 It does not save state. You must set it on powerup. |
#define LED_TYPE LED_STRIP_SK6812 | ||
// #define LED_STRIP_APA106 | ||
// #define LED_STRIP_SM16703 | ||
#ifdef T_EMBED_1101 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be better to use the LED_TYPE as condition instead of T-EMBED? ( I'm trying to remove as much Device related MACROS from the ./src/ files and make it as generic as possible)
Otherwise we would need to add more devices in here when we could be declaring this MACRO on platformio.ini..
I would suggest to use like:
#if LED_TYPE==WS2812B
#define LED_ORDER GRB
#define LED_TYPE_IS_RGBW 0
#define LED_COUNT 8
#elif LED_TYPE==SK6812
#define LED_ORDER RGB
#define LED_TYPE_IS_RGBW 1
#define LED_COUNT 1
#endif
and in cardputer/platformio.ini add -DLED_TYPE=SK6812
after -DHAS_RGB_LED=1
and in t-embed/platformio.ini add -DLED_TYPE=WS2812B
if other LED models compatible with FastLED come, we can just make the proper setup in the platformio
Pending #571 merge to fix up the flags |
Resuming work on this. |
Related: #562
This is a draft request, do not merge yet.
I am using this to checkpoint milestones.