Rf Save File fix interaction with filesystem #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This bug is only presented when no SD card is plugged in. I've now tested with SD card plugged and it works without the fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Use the new method for interacting with the filesystem, because the one used was not working on T-Embed C1101 and the display was freezing.
I decided to use "FS" class to fix this issue.
Also, change to the names of the signals on the filesystem. RAW type will be called raw_ and RcSwitch will be called rcs_.
Types of Changes
Bugfix
Verification
"Save Signal" in RF Scan/Copy menu is now working on C1101
Testing
Yes
Linked Issues
User-Facing Change
Further Comments