List.ItemMetaText for non-icon ItemMeta #1338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fopina
force-pushed
the
listitemmetatext
branch
from
74ff4c3 to
ed88902
Compare
prateekbh
reviewed
Oct 11, 2019
|
will do @prateekbh but do you agree with the change as is? or do you prefer some other approach? |
prateekbh
reviewed
Oct 14, 2019
|
The PR looks good, just a small change |
|
Failed pictures (2): failed-pictures.zip 📮 Posted by artipost.io, through Travis build 598173755, for commit d3f8ad4. |
|
docs updated, but no clue on |
|
@fopina this looks good please add the failed pictures here in your repo: https://github.com/prateekbh/preact-material-components/tree/master/docs/tests/golden/wide |
|
Failed pictures (1): failed-pictures.zip 📮 Posted by artipost.io, through Travis build 598558074, for commit e272410. |
fopina
force-pushed
the
listitemmetatext
branch
from
e272410 to
b5c1128
Compare
|
hope it looks good now 👍 |
prateekbh
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #1337