Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module: appnexusBidAdapter. handle the case when userId is set, but userIdAsEids not #12705

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

olafbuitelaar
Copy link
Contributor

Type of change

  • Bugfix

Description of change

it appears that when appnexus tries to populate the eids, a scenario can exists where the bidRequests[0].userId is set, but the bidRequests[0].userIdAsEids not in which case the adapter produces an error;
image

Copy link

Tread carefully! This PR adds 2 linter errors (possibly disabled through directives):

  • modules/appnexusBidAdapter.js (+2 errors)

@patmmccann
Copy link
Collaborator

@olafbuitelaar are you aware of what causes "a scenario can exists where the bidRequests[0].userId is set, but the bidRequests[0].userIdAsEids is not". Is there a userid module that does not set the eid that is the only one configured?

@olafbuitelaar
Copy link
Contributor Author

i don't know the root cause, but i can see that the user module intentIqIdSystem populates the userId object, but the userIdAsEids is empty;
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants