Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with connection for tests #3704

Merged
merged 10 commits into from
Jan 29, 2025
Merged

Fix issue with connection for tests #3704

merged 10 commits into from
Jan 29, 2025
+117 −48

Conversation

osulzhenko
Copy link
Collaborator

@osulzhenko osulzhenko commented Jan 27, 2025 •
edited
Loading

🔧 Type of changes

  • new bid adapter
  • bid adapter update
  • new feature
  • new analytics adapter
  • new module
  • module update
  • bugfix
  • documentation
  • configuration
  • dependency update
  • tech debt (test coverage, refactorings, etc.)

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

  • verify email contact works
  • NO fully dynamic hostnames
  • geographic host parameters are NOT required
  • direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
  • if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
  • cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

  • Are your changes following our code style guidelines?
  • Are there any breaking changes in your code?
  • Does your test coverage exceed 90%?
  • Are there any erroneous console logs, debuggers or leftover code in your changes?

@osulzhenko osulzhenko added tests Functional or other tests do not port labels Jan 27, 2025
@osulzhenko osulzhenko requested a review from marki1an January 27, 2025 12:13
@osulzhenko osulzhenko self-assigned this Jan 27, 2025
@osulzhenko osulzhenko force-pushed the functional-tests/fix-connection-issue branch from 629a847 to 7ca69fb Compare January 27, 2025 20:18
@osulzhenko osulzhenko force-pushed the functional-tests/fix-connection-issue branch 2 times, most recently from d750dc8 to 50b59b4 Compare January 28, 2025 12:21
@osulzhenko
Revert "update after review"
34022e9 
This reverts commit d750dc8.
@osulzhenko
Merge branch 'refs/heads/master' into functional-tests/fix-connection…
9eeae0e 
…-issue

# Conflicts:
#	src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy
@osulzhenko
Revert "Revert "update after review""
eff1812 
This reverts commit 34022e9.
@osulzhenko
update functional tests
e7a1e41
@osulzhenko
update functional tests
9fbb44b
marki1an
marki1an previously approved these changes Jan 29, 2025
View reviewed changes
.../groovy/org/prebid/server/functional/tests/privacy/TcfBasicTransmitEidsActivitiesSpec.groovy Outdated
@@ -32,6 +32,10 @@ class TcfBasicTransmitEidsActivitiesSpec extends PrivacyBaseSpec {

private final PrebidServerService activityPbsServiceExcludeGvl = pbsServiceFactory.getService(PBS_CONFIG)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add static keyword

@CTMBNara CTMBNara merged commit 3e91c96 into master Jan 29, 2025
8 checks passed
@CTMBNara CTMBNara deleted the functional-tests/fix-connection-issue branch January 29, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marki1an marki1an marki1an approved these changes

Assignees

@osulzhenko osulzhenko

Labels
do not port tests Functional or other tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@osulzhenko @marki1an @CTMBNara