Fixing placement parsing logic

prebid · Jul 5, 2024 · 914cd4c · 914cd4c
1 parent 2cf98db
commit 914cd4c
Show file tree

Hide file tree

Showing 4 changed files with 36 additions and 19 deletions.
diff --git a/adapters/triplelift_native/triplelift_native.go b/adapters/triplelift_native/triplelift_native.go
@@ -33,14 +33,29 @@ type TripleliftNativeExtInfo struct {
 	PublisherWhitelistMap map[string]struct{}
 }
 
+type ExtImpData struct {
+	TagCode string `json:"tag_code"`
+}
+
+type ExtImp struct {
+	adapters.ExtImpBidder
+	Data *ExtImpData `json:"data,omitempty"`
+}
+
 func getBidType(ext TripleliftRespExt) openrtb_ext.BidType {
 	return openrtb_ext.BidTypeNative
 }
 
-func processImp(imp *openrtb2.Imp, req *openrtb2.BidRequest) error {
+func processImp(imp *openrtb2.Imp, request *openrtb2.BidRequest) error {
 	// get the triplelift extension
 	var ext adapters.ExtImpBidder
 	var tlext openrtb_ext.ExtImpTriplelift
+	var siteCopy openrtb2.Site
+	var extData ExtImpData
+
+	if request.Site != nil {
+		siteCopy = *request.Site
+	}
 
 	if err := json.Unmarshal(imp.Ext, &ext); err != nil {
 		return err
@@ -54,10 +69,14 @@ func processImp(imp *openrtb2.Imp, req *openrtb2.BidRequest) error {
 	if tlext.InvCode == "" {
 		return fmt.Errorf("no inv_code specified")
 	}
-	if req.Site != nil {
-		siteCopy := *req.Site
-		if siteCopy.Domain == "msn.com" {
-			imp.TagID = tlext.TagCode
+
+	fmt.Println(extData)
+	fmt.Println(extData.TagCode)
+	fmt.Println(ext)
+	if extData.TagCode != "" {
+		if siteCopy.Publisher.Domain == "msn.com" {
+			fmt.Println(extData.TagCode)
+			imp.TagID = extData.TagCode
 		} else {
 			imp.TagID = tlext.InvCode
 		}

diff --git a/adapters/triplelift_native/triplelift_nativetest/exemplary/msn-params.json b/adapters/triplelift_native/triplelift_nativetest/exemplary/msn-params.json
@@ -1,7 +1,7 @@
 {
     "mockBidRequest": {
       "id": "test-request-id",
-      "site": { "publisher": {"id":"foo","name":"foo"}, "domain": "msn.com"},
+      "site": { "publisher": {"id":"foo","name":"foo", "domain": "msn.com"}},
       "imp": [
         {
           "native": {
@@ -38,16 +38,19 @@
                   "bidder": {
                     "inventoryCode": "foo",
                      "floor" : 20
+                  },
+                  "data": {
+                    "tag_code": "bar"
                   }
                 }
               }
             ],
-          "site": {
-              "publisher": {
-                "id": "foo",
-                "name": "foo"
-              }, 
-              "domain": "msn.com"
+            "site": {
+                "publisher": {
+                    "id":"foo",
+                    "name":"foo",
+                    "domain": "msn.com"
+                }
             }
           },
           "impIDs":["test-imp-id"]

diff --git a/openrtb_ext/imp_triplelift.go b/openrtb_ext/imp_triplelift.go
@@ -2,7 +2,6 @@ package openrtb_ext
 
 // ExtImpTriplelift defines the contract for bidrequest.imp[i].ext.prebid.bidder.triplelift
 type ExtImpTriplelift struct {
-	InvCode string   `json:"inventoryCode"`
-	Floor   *float64 `json:"floor"`
-	TagCode string   `json:"tag_code"`
+	InvCode string          `json:"inventoryCode"`
+	Floor   *float64        `json:"floor"`
 }
diff --git a/static/bidder-params/triplelift_native.json b/static/bidder-params/triplelift_native.json
@@ -9,10 +9,6 @@
       "type": "string",
       "description": "TripleLift inventory code for this ad unit (provided to you by your partner manager)"
     },
-    "tag_code": {
-      "type": "string",
-      "description": "TripleLift placement name for MSN"
-    },
     "floor" :  {"description" : "the bid floor, in usd", "type": "number" }
   },
   "required": ["inventoryCode"]