Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Adapter: Oraki #3736

Closed
wants to merge 1 commit into from
Closed

New Adapter: Oraki #3736

wants to merge 1 commit into from

Conversation

BenOraki
Copy link
Contributor

@BenOraki BenOraki commented Jun 7, 2024

Copy link

github-actions bot commented Jun 7, 2024

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, aa876e3

oraki

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:29:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:36:	MakeRequests	76.5%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:91:	makeRequest	85.7%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:109:	MakeBids	100.0%
github.com/prebid/prebid-server/v2/adapters/oraki/oraki.go:146:	getBidType	100.0%
total:								(statements)	86.6%

@@ -0,0 +1,18 @@
endpoint: "https://eu1.oraki.io/pserver"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

endpoint is not reachable

curl -i --location --request POST 'https://eu1.oraki.io/pserver'

HTTP/2 521
date: Fri, 28 Jun 2024 10:32:02 GMT
content-type: text/plain; charset=UTF-8
content-length: 15
report-to: {"endpoints":[{"url":"https:\/\/a.nel.cloudflare.com\/report\/v4?s=Vwp%2BVk0ag0PLQ%2FTPo7qSfCtFg2h41Qbo2UZqN2IhTZ3H21BX19f2g0GEM16nd35jJXMYrvs5Yb2SyeYdZR3bPLaiyLoQYI7ppJLMvO1s0J4wIxT8Ljo3MLRyLqSpWIk%3D"}],"group":"cf-nel","max_age":604800}
nel: {"success_fraction":0,"report_to":"cf-nel","max_age":604800}
x-frame-options: SAMEORIGIN
referrer-policy: same-origin
cache-control: private, max-age=0, no-store, no-cache, must-revalidate, post-check=0, pre-check=0
expires: Thu, 01 Jan 1970 00:00:01 GMT
server: cloudflare
cf-ray: 89ad023dcb94f3e1-BOM
alt-svc: h3=":443"; ma=86400

error code: 521

@@ -0,0 +1,18 @@
endpoint: "https://eu1.oraki.io/pserver"
maintainer:
email: "[email protected]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[email protected] seems associated to an individual. Prebid recommends to use an group or organization email as maintainer email.

Comment on lines +16 to +18
redirect:
url: "https://sync.oraki.io/pbserver?gdpr={{.GDPR}}&gdpr_consent={{.GDPRConsent}}&us_privacy={{.USPrivacy}}&gpp={{.GPP}}&gpp_sid={{.GPPSID}}&redir={{.RedirectURL}}"
userMacro: "[UID]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redirect url is not working

https://sync.oraki.io/pbserver?gdpr=&gdpr_consent=&us_privacy=&gpp=&gpp_sid={{.GPPSID}}&redir=https%3A%2F%2Fprebid.adnxs.com%2Fpbs%2Fv1%2Fsetuid%3Fbidder%3Doraki%26gdpr%3D%26gdpr_consent%3D%26f%3Di%26uid%3D%22%5BUID%5D%22

sync.oraki.io web server is down

image

@przemkaczmarek
Copy link
Collaborator

URL still doesnt work
image

@onkarvhanumante
Copy link
Contributor

Closing PR as this is in stale state for a month. @BenOraki can reopen this PR with updated changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants