Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Criteo: Add support for paapi #3759

Merged
merged 1 commit into from
Jul 30, 2024
Merged

Criteo: Add support for paapi #3759

merged 1 commit into from
Jul 30, 2024

Conversation

vraybaud
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, 2a765a8

criteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:43:	Builder		100.0%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:51:	MakeRequests	80.0%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:67:	MakeBids	92.9%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:130:	getBidMeta	100.0%
total:									(statements)	92.3%

@bsardo bsardo self-assigned this Jun 27, 2024
@bsardo bsardo changed the title Criteo Bid Adapter : add support for paapi Criteo: Add support for paapi Jun 27, 2024
guscarreon
guscarreon reviewed Jul 17, 2024
View reviewed changes
adapters/criteo/criteo.go Outdated Show resolved Hide resolved
adapters/criteo/criteo.go Outdated Show resolved Hide resolved
adapters/criteo/criteo.go Outdated Show resolved Hide resolved
adapters/criteo/criteo.go Show resolved Hide resolved
@guscarreon guscarreon self-assigned this Jul 17, 2024
@github-actions GitHub Actions
Copy link

Code coverage summary

Note:

  • Prebid team doesn't anticipate tests covering code paths that might result in marshal and unmarshal errors
  • Coverage summary encompasses all commits leading up to the latest one, ee570de

criteo

Refer here for heat map coverage report

github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:42:	Builder				100.0%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:50:	MakeRequests			80.0%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:66:	MakeBids			90.9%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:116:	ParseFledgeAuctionConfigs	100.0%
github.com/prebid/prebid-server/v2/adapters/criteo/criteo.go:141:	getBidMeta			100.0%
total:									(statements)			93.2%

guscarreon
guscarreon approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@guscarreon guscarreon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bsardo bsardo merged commit 843a81c into prebid:master Jul 30, 2024
5 checks passed
@cross-repo-issue-creation cross-repo-issue-creation bot mentioned this pull request Jul 30, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@przemkaczmarek przemkaczmarek przemkaczmarek approved these changes

@guscarreon guscarreon guscarreon approved these changes

Assignees

@guscarreon guscarreon

@przemkaczmarek przemkaczmarek

Labels
None yet
Projects
Prebid Server Prioritization
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vraybaud @guscarreon @przemkaczmarek @bsardo